-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
EEBus meter: add OHPCF #26159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andig
wants to merge
8
commits into
master
Choose a base branch
from
feat/ohpcf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
EEBus meter: add OHPCF #26159
+40
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- In
NewConfigurationyou now pass an empty[]shipapi.DeviceCategoryType{}and later an empty string toRegisterRemoteSKI; if the APIs acceptnilor a dedicated constant/typed value instead, prefer those over magic empty values to make the intent clearer and avoid unnecessary allocations. - The commented-out
replacedirectives forship-goandspine-goingo.modlook like dead configuration; consider either removing them or adding a brief note explaining when they should be toggled to avoid confusion for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `NewConfiguration` you now pass an empty `[]shipapi.DeviceCategoryType{}` and later an empty string to `RegisterRemoteSKI`; if the APIs accept `nil` or a dedicated constant/typed value instead, prefer those over magic empty values to make the intent clearer and avoid unnecessary allocations.
- The commented-out `replace` directives for `ship-go` and `spine-go` in `go.mod` look like dead configuration; consider either removing them or adding a brief note explaining when they should be toggled to avoid confusion for future maintainers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
@copilot apply |
Contributor
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: andig <184815+andig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.