Skip to content

Conversation

@andig
Copy link
Member

@andig andig commented Dec 22, 2025

No description provided.

@andig andig added the experimental Experimental feature label Dec 22, 2025
@andig andig marked this pull request as draft December 22, 2025 17:50
@andig andig added the backlog Things to do later label Dec 22, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In NewConfiguration you now pass an empty []shipapi.DeviceCategoryType{} and later an empty string to RegisterRemoteSKI; if the APIs accept nil or a dedicated constant/typed value instead, prefer those over magic empty values to make the intent clearer and avoid unnecessary allocations.
  • The commented-out replace directives for ship-go and spine-go in go.mod look like dead configuration; consider either removing them or adding a brief note explaining when they should be toggled to avoid confusion for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `NewConfiguration` you now pass an empty `[]shipapi.DeviceCategoryType{}` and later an empty string to `RegisterRemoteSKI`; if the APIs accept `nil` or a dedicated constant/typed value instead, prefer those over magic empty values to make the intent clearer and avoid unnecessary allocations.
- The commented-out `replace` directives for `ship-go` and `spine-go` in `go.mod` look like dead configuration; consider either removing them or adding a brief note explaining when they should be toggled to avoid confusion for future maintainers.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig
Copy link
Member Author

andig commented Dec 25, 2025

@copilot apply

go mod tidy

Copy link
Contributor

Copilot AI commented Dec 25, 2025

@andig I've opened a new pull request, #26180, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits December 25, 2025 18:11
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: andig <184815+andig@users.noreply.github.com>
@andig andig changed the title Add EEBus OHPCF EEBus meter: add OHPCF Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Things to do later experimental Experimental feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants