Skip to content

Conversation

@etdte
Copy link
Owner

@etdte etdte commented Mar 11, 2019

This pull request includes the changes for upgrading to Laravel 5.8. Feel free to commit any additional changes to the shift-12866 branch.

Before merging, you should:

  • Checkout the shift-12866 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 5.8
  • Run composer update (if the pre-scripts fail, add --no-scripts)
  • Thoroughly test your application

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

Laravel recommends using the `Str` and `Arr` class methods directly instead of the respective helper functions. These helper functions are [deprecated in Laravel 5.8][1] and will be removed in a future version.

[1]: laravel/framework#26898
@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.8 configuration files and merge any changes:

  • config/app.php

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

⚠️ Laravel 5.8 introduced a set of AWS environment variables to help consolidate configuring AWS services. You should rename the following environment variables to their new AWS names.

  • SQS_KEY to AWS_ACCESS_KEY_ID
  • SQS_SECRET to AWS_SECRET_ACCESS_KEY
  • SQS_REGION to AWS_DEFAULT_REGION
  • SES_KEY to AWS_ACCESS_KEY_ID
  • SES_SECRET to AWS_SECRET_ACCESS_KEY
  • SES_REGION to AWS_DEFAULT_REGION

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

⚠️ Laravel 5.8 changed several of the core contracts with new implementations and methods. You should review the Upgrade Guide for more detail on these respective changes:

Shift found references to these contracts within:

  • app/Http/Controllers/Auth/RegisterController.php

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

ℹ️ Laravel 5.8 changed the minimum requirement for password length from 6 characters to 8 character. While this change is not required, you should consider this opportunity to review the password policy for your application.

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

⚠️ If you are using JSON values in your MySQL or MariaDB tables, the query builder now returns unquoted JSON values in Laravel 5.8.

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

⚠️ If you are using SQLite, the oldest supported version in Laravel 5.8 is SQLite 3.7.11. Laravel recommends running SQLite 3.8.8 or higher.

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

⚠️ The Nexmo and Slack notification channels have been extracted into first-party packages. To use these channels in your application, run the following command to require the respective packages:

composer require laravel/nexmo-notification-channel
composer require laravel/slack-notification-channel

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

⚠️ Laravel 5.8 correctly pluralizes multi-word model names ending in a word with an irregular pluralization. For example, Laravel 5.7 incorrectly pluralized the table name for the UserFeedback model as user_feedbacks. Laravel 5.8 correctly pluralizes this table name as user_feedback.

If you were relying on this irregular pluralization, you should rename your table name or set the $table property for your model. If you were overriding this behavior by setting the $table property, you may remove it and now rely on the framework.

@etdte
Copy link
Owner Author

etdte commented Mar 11, 2019

🎉 Congratulations, you're now running the latest version of Laravel. You can now use some of the micro Shifts to ensure your app is fully upgraded and following the Laravel recommended and community practices.

  • Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
  • Laravel Fixer automates many of the suggestions found by the Analyzer and Linter.
  • Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants