Skip to content

Conversation

@finger563
Copy link
Contributor

No description provided.

…t enabling pin filtering prevents light sleep
Copilot AI review requested due to automatic review settings December 17, 2025 04:08
@finger563 finger563 merged commit 79ef310 into main Dec 17, 2025
101 of 103 checks passed
@finger563 finger563 deleted the doc/interrupt-light-sleep-update branch December 17, 2025 04:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation to indicate that enabling GPIO pin filtering (either PIN_GLITCH_FILTER or FLEX_GLITCH_FILTER) prevents light sleep mode from being enabled. This is important operational information for users who need to understand power management implications.

Key Changes

  • Added inline documentation note to the filter_type member explaining the light sleep behavior constraint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FilterType::NONE; ///< The type of filter to use. If set to FLEX_GLITCH_FILTER, the
///< filter_config should be set.
///<
///< @note If not FilterType::NONE, then light
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation uses @note but the codebase consistently uses \note for Doxygen notes (see lines 100 and 102 in the same file). Please change @note to \note to maintain consistency with the existing documentation style.

Suggested change
///< @note If not FilterType::NONE, then light
///< \note If not FilterType::NONE, then light

Copilot uses AI. Check for mistakes.
FilterType filter_type =
FilterType::NONE; ///< The type of filter to use. If set to FLEX_GLITCH_FILTER, the
///< filter_config should be set.
///<
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty comment line seems unnecessary. The note could be added directly after the existing comment on line 136, or the empty line could be removed and the note placed immediately after. This would be more consistent with other multi-line member comments in the file (see lines 123-129 for example).

Suggested change
///<

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants