Enhance ITypeComp.Bind tests and type hints.
#906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test case to verify that calling `ITypeComp.Bind` with a non-existent name correctly raises a `NameError`.
…POBJ`. Adds clarifying comments within the `ITypeComp.Bind` method in `typeinfo.py` to explain the nature and rarity of the `DESCKIND_IMPLICITAPPOBJ` type description kind.
Adds clarifying comments within the `ITypeComp.Bind` method in `typeinfo.py` to explain that `DESCKIND_MAX` is not a valid return value from `ITypeComp::Bind` and implies a malformed type library.
Refines the return type hints for the `ITypeComp.Bind` method in `typeinfo.py` to use `typing.Literal` for the kind string, providing more precise type information and enhancing static analysis capabilities.
junkmd
added
tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 86.11% 86.26% +0.14%
==========================================
Files 132 132
Lines 12288 12326 +38
==========================================
+ Hits 10582 10633 +51
+ Misses 1706 1693 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces comprehensive tests for
ITypeComp, improving type hints forITypeComp.Bind.Improvements
Enhanced Type Hints
The return type hints for
ITypeComp.Bindnow leveragetyping.Literalto precisely define the possible "kind" strings ("function", "variable", "type"). This change allows static analysis tools to provide more accurate feedback.Comprehensive Testing
New tests have been added to cover a wider range of
ITypeComp.Bind's behaviors, including binding to enum members, interface members, and enum types.Clearer Documentation
Clarifying comments have been integrated directly into the
ITypeComp.Bindmethod's implementation.These comments explain the rare
DESCKIND_IMPLICITAPPOBJtype and the implications of encounteringDESCKIND_MAX, demystifying complex COM behaviors for users and maintainers.