Skip to content

Conversation

@Sparticuz
Copy link

Rocknix replaced JELOS. Also added missing systems for it.

Rocknix replaced JELOS. Also added missing systems for it.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome

Thank you for your first pull request, @Sparticuz! If you haven't yet, please familiarize yourself with Igir's contribution guidelines.

Some GitHub Actions CI workflows may not automatically run for you due to GitHub's security best practices, so a maintainer may need to manually approve the workflows to run. As a result, it is important to make sure tests pass locally before submitting a pull request to help ensure a fast review. Thank you!

Comment generated by the GitHub First Interaction workflow.

@Sparticuz Sparticuz changed the title Add Rocknix system feature: Add Rocknix system Jul 3, 2025
@github-actions github-actions bot changed the title feature: Add Rocknix system Feature: Add Rocknix system Jul 3, 2025
@emmercm
Copy link
Owner

emmercm commented Jul 11, 2025

@Sparticuz thank you for this!

Here's what I'm thinking: it probably makes sense to add a new {rocknix} token for clarity, that for now will behave the same as {jelos} (same underlying config, as you have here). That would require updates to:

  • Renaming {jelos} in docs/output/tokens.md
  • Moving docs/usage/handheld/jelos.md to docs/usage/handheld/rocknix.md and adding a redirect in mkdocs.yml
  • Renaming {jelos} in src/modules/argumentsParser.ts
  • Adding {rocknix} to src/types/outputFactory.ts
  • Adding {rocknix} to test/outputFactory.test.ts

the end result being a backward-compatible rename, where {jelos} can be phased out later, but for now will just be removed from documentation.

Is this something you'd like to try your hand at?

@Sparticuz
Copy link
Author

Feel free to take what I've done and build it out. I won't be able to contribute anytime soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants