set worker_name compatible with k8s horizontal pod autoscaling #19329
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
recreated because license/cla signing (#19285) |
MadLittleMods
requested changes
Dec 29, 2025
Comment on lines
+262
to
+264
| self.worker_name = self.worker_app | ||
| if self.worker_app: | ||
| self.worker_name = config.get("worker_name", environ.get("HOSTNAME")) |
Contributor
There was a problem hiding this comment.
The logic here just doesn't make sense. Mentioned in #19285 (comment)
Additionally,
This changes the previous behavior where we previously read from
config.get("worker_name")and had a fallback to theself.worker_app.Now it will
config.get("worker_name")->environ.get("HOSTNAME")Overall, I'm not very convinced of the change yet.
And I'm still not following with what you wrote there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master worker needs to "know" names of workers by type. this patch allows to use kubernetes HPA because worker name is based on hostname which is equals to pod name in kubernetes
Previous PR: #19285 (recreated because license/cla signing)