chore: upgrade spack to v1.1.0 #34

wdconinc · 2025-11-15T00:31:41Z

Briefly, what does this PR introduce?

Needs:

This PR upgrades spack to v1.1.0, https://github.com/spack/spack/releases/tag/v1.1.0.

What kind of change does this PR introduce?

Bug fix (issue #__)
New feature (issue #__)
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copilot

Pull Request Overview

This PR upgrades the Spack package manager version from v1.0.2 to v1.1.0 to incorporate the latest upstream changes and improvements from the Spack project.

Updates the SPACK_VERSION variable to reference the v1.1.0 release
Maintains existing cherry-picks for custom patches
No breaking changes or behavior modifications

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

containers/debian/Dockerfile

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

containers/eic/Dockerfile

spack-environment/packages_root_with_opengl.yaml

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spack-environment/packages.yaml

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

containers/eic/Dockerfile

Removed llvm package requirement for gold.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

spack-environment/packages.yaml

spack-environment/tf/spack.yaml

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

containers/eic/Dockerfile

.github/workflows/build-push.yml

containers/eic/Dockerfile

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wdconinc · 2025-12-29T17:29:10Z

Interesting... Now this picks up clang@15 in eic_tf (which was built for numba > llvmlite) to build edm4eic, but only in the second level epic/spack.yaml environment... https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/7027809#L2542

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-30T20:36:04Z

.github/workflows/build-push.yml

          runner: ubuntu-latest
          PLATFORM: linux/amd64
          target: builder_concretization_default
+          SPACK_DUPLICATE_ALLOWLIST: "epic|llvm|py-setuptools|py-urllib3"


The SPACK_DUPLICATE_ALLOWLIST for the 'cuda' environment is inconsistent between GitLab CI and GitHub workflows. In .gitlab-ci.yml (line 480), the 'cuda' environment includes the extended allowlist with py-dask, py-dask-awkward, py-dask-histogram, py-distributed, and py-requests. However, in .github/workflows/build-push.yml, the 'cuda' environment only has the basic allowlist. This should be updated to match the GitLab CI configuration to ensure consistent duplicate handling across both CI systems.

Suggested change

SPACK_DUPLICATE_ALLOWLIST: "epic|llvm|py-setuptools|py-urllib3"

SPACK_DUPLICATE_ALLOWLIST: "epic|llvm|py-setuptools|py-urllib3|py-dask|py-dask-awkward|py-dask-histogram|py-distributed|py-requests"

Copilot AI review requested due to automatic review settings November 15, 2025 00:31

Copilot started reviewing on behalf of wdconinc November 15, 2025 00:32 View session

Copilot finished reviewing on behalf of wdconinc November 15, 2025 00:32

Copilot AI reviewed Nov 15, 2025

View reviewed changes

wdconinc changed the title ~~Upgrade spack to v1.1.0~~ Upgrade Spack to v1.1.0 Nov 15, 2025

wdconinc force-pushed the spack-1.1.0 branch from d83f05f to 28b4f41 Compare November 16, 2025 03:05

This comment was marked as resolved.

Sign in to view

This comment was marked as off-topic.

Sign in to view

wdconinc force-pushed the spack-1.1.0 branch from 28b4f41 to 6893049 Compare November 18, 2025 23:53

wdconinc commented Nov 19, 2025

View reviewed changes

containers/debian/Dockerfile Outdated Show resolved Hide resolved

wdconinc force-pushed the spack-1.1.0 branch 8 times, most recently from 8cc24d5 to 8d3576f Compare November 21, 2025 21:46

wdconinc mentioned this pull request Nov 23, 2025

chore: upgrade spack-packages to v2025.11.0 #35

Open

13 tasks

wdconinc force-pushed the spack-1.1.0 branch from 8d3576f to 515068c Compare November 24, 2025 02:19

Copilot AI review requested due to automatic review settings November 26, 2025 01:59

Copilot started reviewing on behalf of wdconinc November 26, 2025 02:04 View session

Copilot finished reviewing on behalf of wdconinc November 26, 2025 02:08

Copilot AI reviewed Nov 26, 2025

View reviewed changes

containers/eic/Dockerfile Show resolved Hide resolved

spack-environment/packages_root_with_opengl.yaml Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 26, 2025 02:19

Copilot started reviewing on behalf of wdconinc November 26, 2025 02:26 View session

Copilot finished reviewing on behalf of wdconinc November 26, 2025 02:27

Copilot AI reviewed Nov 26, 2025

View reviewed changes

spack-environment/packages.yaml Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 26, 2025 14:12

Copilot started reviewing on behalf of wdconinc November 26, 2025 14:15 View session

wdconinc force-pushed the spack-1.1.0 branch from d4a6845 to ad08a47 Compare December 27, 2025 20:58

Copilot AI reviewed Dec 27, 2025

View reviewed changes

containers/eic/Dockerfile Outdated Show resolved Hide resolved

containers/eic/Dockerfile Outdated Show resolved Hide resolved

containers/eic/Dockerfile Show resolved Hide resolved

wdconinc added 2 commits December 27, 2025 15:07

fix: build argument for spack duplicates

5173a88

Remove llvm gold requirement from packages.yaml

2942ddb

Removed llvm package requirement for gold.

wdconinc force-pushed the spack-1.1.0 branch from ad08a47 to 2942ddb Compare December 27, 2025 21:08

wdconinc added 2 commits December 28, 2025 15:58

fix: concretizer: unify: when_possible due to py-numba ^llvm@15

51045ea

fix: packages: pin or constrain py-numpy and swig

924a0a6

Copilot AI review requested due to automatic review settings December 28, 2025 22:01

Copilot started reviewing on behalf of wdconinc December 28, 2025 22:02 View session

Copilot AI reviewed Dec 28, 2025

View reviewed changes

spack-environment/packages.yaml Show resolved Hide resolved

spack-environment/tf/spack.yaml Show resolved Hide resolved

wdconinc added 2 commits December 28, 2025 16:18

fix: pass duplicate allow list with matrix; default to empty

143c6f1

fix: avoid premature error on grep -v

9c43d56

Copilot AI review requested due to automatic review settings December 29, 2025 00:46

Copilot started reviewing on behalf of wdconinc December 29, 2025 00:47 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

containers/eic/Dockerfile Outdated Show resolved Hide resolved

.github/workflows/build-push.yml Show resolved Hide resolved

containers/eic/Dockerfile Show resolved Hide resolved

fix: tee to duplicates_all.txt

de326a4

Copilot AI review requested due to automatic review settings December 29, 2025 01:08

Copilot started reviewing on behalf of wdconinc December 29, 2025 01:09 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

wdconinc requested a review from veprbl December 29, 2025 04:10

wdconinc added 2 commits December 29, 2025 13:15

fix: revert back from set -ex to set -e

9e972b5

fix: packages: py-matplotlib: require: %clang@18:

b0c774d

wdconinc changed the title ~~Upgrade Spack to v1.1.0~~ chore: upgrade spack to v1.1.0 Dec 30, 2025

wdconinc disabled auto-merge December 30, 2025 16:38

wdconinc enabled auto-merge (squash) December 30, 2025 16:38

fix: be explicit about language/compiler providers

c95a787

Copilot AI review requested due to automatic review settings December 30, 2025 20:32

Copilot started reviewing on behalf of wdconinc December 30, 2025 20:33 View session

Copilot AI reviewed Dec 30, 2025

View reviewed changes

	SPACK_DUPLICATE_ALLOWLIST: "epic\|llvm\|py-setuptools\|py-urllib3"
	SPACK_DUPLICATE_ALLOWLIST: "epic\|llvm\|py-setuptools\|py-urllib3\|py-dask\|py-dask-awkward\|py-dask-histogram\|py-distributed\|py-requests"

chore: upgrade spack to v1.1.0 #34

Are you sure you want to change the base?

chore: upgrade spack to v1.1.0 #34

Conversation

wdconinc commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

This comment was marked as resolved.

This comment was marked as off-topic.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

wdconinc commented Dec 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wdconinc commented Nov 15, 2025 •

edited

Loading