Skip to content

Conversation

@wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR changes slightly the build structure from a two-track (builder, runtime) build to more of a three-track build (builder default, builder custom, runtime).

This primarily allows for concretization of the builder custom phase before any installation is done. Since we've been having some failures at that stage, it's annoying to have to wait until the installation is far along. This will trigger those failures earlier.

Copilot AI review requested due to automatic review settings December 30, 2025 01:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Dockerfile build structure from a two-track (builder, runtime) to a three-track build (builder concretization, builder installation, runtime). The key benefit is that custom version concretization now happens earlier in the build process, allowing concretization failures to surface before expensive installation steps are executed.

Key Changes

  • Modified builder_concretization_custom to derive from builder_concretization_default instead of builder_installation_default, enabling earlier failure detection
  • Consolidated runtime stages by merging runtime_concretization_* and runtime_installation_* into single runtime_default and runtime_custom stages
  • Updated documentation and ASCII diagram to reflect the new three-track architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 30, 2025 04:58
@wdconinc

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 2 commits December 29, 2025 23:06
* Initial plan

* docs: update architecture.md mermaid diagram for three-track build

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 30, 2025 05:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Dec 30, 2025

@wdconinc I've opened a new pull request, #117, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants