Skip to content

Conversation

@nelhage
Copy link

@nelhage nelhage commented Dec 18, 2025

Add the py-to-int primitive that extracts a Python integer as i64, complementing the existing from_int method for bidirectional conversion.

Implemented using Claude Code, but reviewed by me before submission. I would find this useful for some current work, where I end up moving between the Python domain and the egglog domain fairly heavily.

Add the py-to-int primitive that extracts a Python integer as i64,
complementing the existing from_int method for bidirectional conversion.
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #394 will not alter performance

Comparing nelhage:claude/implement-pyobject-to-int-NUp85 (35ea382) with main (6a892ec)

Summary

✅ 14 untouched

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you add a little test for this in test_high_level?

Yeah the current set of primitives with py objects are rather arbitrary, would be good to fill them out more.

@nelhage
Copy link
Author

nelhage commented Dec 18, 2025

Done! Looks like the test failures are infra issues, at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants