fix coverage reporting for gcc 8 and code that uses templates #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 8 extended the output of gcov, some of the issue have been fixed, e.g. #127, #140
However the new reporting for "instances" is missing. As a result cpp-coveralls reports:
The fix is quite simple: ignore lines that are smaller than the size of the array. This works because gcov reports the total number of executions in the 1st occurrences, the instance reports than report the individual counts which sum up to the total count. For now coveralls does not support template variants, therefore we can just skip over it.