Add an NFS proxy server for cross-sandbox persistence #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| } | ||
|
|
||
| func (p *Proxy) getPrefixFromSandbox(conn net.Conn) (string, error) { | ||
| sbx, err := p.sandboxes.GetByHostPort(conn.RemoteAddr().String()) |
There was a problem hiding this comment.
Security issue: Sandbox isolation could be bypassed. The GetByHostPort method matches based on IP address, but conn.RemoteAddr() returns the client's IP which could be spoofed or shared between sandboxes if they use NAT. Consider using a more secure authentication mechanism.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+149
to
+153
| data, err := exec.CommandContext(ctx, "bash", "-c", fmt.Sprintf(` | ||
| set -e | ||
| mkdir -p %q | ||
| mount -v -t nfs -o mountproto=tcp,mountport=2049,proto=tcp,port=2049,nfsvers=3,noacl %q %q | ||
| `, path, nfsTarget, path)).CombinedOutput() |
Check failure
Code scanning / CodeQL
Command built from user-controlled sources Critical
Contributor
Author
There was a problem hiding this comment.
This is executed in their sandbox with sudo credentials. There's nothing for them to hack, they already have root.
djeebus
force-pushed
the
add-nfs-server
branch
from
03d6852 to
ebca825
Compare
This reverts commit 91da71d.
nfs needs them, quietly fail to adhere to spec instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.