Disable stack traces #1590
Disable stack traces #1590
Conversation
These extra logs provide very little value, but take up a lot of physical and visual space
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
packages/shared/pkg/logger/logger.go
Outdated
| // Console logging configuration | ||
| config := zap.Config{ | ||
| DisableStacktrace: loggerConfig.DisableStacktrace, | ||
| DisableStacktrace: true, |
There was a problem hiding this comment.
Hardcoding DisableStacktrace: true ignores the LoggerConfig.DisableStacktrace field passed by callers. This breaks the API contract where callers might intentionally pass DisableStacktrace: false to enable stacktraces for debugging. Consider: DisableStacktrace: loggerConfig.DisableStacktrace or remove the field from the config struct if it's no longer needed.
| IsInternal: config.IsInternal, | ||
| IsDebug: true, | ||
| DisableStacktrace: !config.IsInternal, | ||
| DisableStacktrace: true, |
There was a problem hiding this comment.
Same issue: hardcoding DisableStacktrace: true ignores the conditional logic \!config.IsInternal that was previously used. This means internal services lose the ability to enable stacktraces even when needed for debugging.
There was a problem hiding this comment.
I don't think there's a reason to log stack traces for every log message
jakubno
left a comment
jakubno
left a comment
There was a problem hiding this comment.
This may be also worth checking Development field in zap.Config in
packages/shared/pkg/logger/logger.go
These extra logs provide very little value, but take up a lot of physical and visual space