Add keywords parameters for slack backend #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No luck with this? Having the sender name as "Slack Api Tester" is pretty annoying. |
|
That feature would be also useful for me to be able to use different sender icons, depending on the context (e.g. warning vs alert). @dschep Do you plan to accept it (in one way or another) or definitely not and it is required to use a patched version? |
Owner
|
i have no issue merging if the merge conflicts were resolved |
|
@AntoinePrv It has been some time, but maybe you still use that feature and would like to have it merged upstream (by resolving the conflicts)? :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added keywords parameters in the slack backend to enable other parameters from the config, such as the username and the image (Fancier than the
Slack Api Testerdefault name).I mentioned it in the
readmeand also corrected:if you use the @ symbol the message is send to a Slack userwhich is no longer supported by Slack Api (only user ids are supported).Thanks