Skip to content

fix: useEffect dependency and cleanup list keys #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anirudh-020505 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: useEffect dependency and cleanup list keys #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23dc914
fix: useEffect dependency and cleanup list keys
Anirudh-020505 Dec 4, 2025
322c356
fix: restore index i in Templates.jsx map callback
Anirudh-020505 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/EditorCanvas/Canvas.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,13 +646,13 @@ export default function Canvas() {
x:
prev.pan.x -
(pointer.spaces.diagram.x - prev.pan.x) *
eagernessFactor *
Math.sign(e.deltaY),
eagernessFactor *
Math.sign(e.deltaY),
y:
prev.pan.y -
(pointer.spaces.diagram.y - prev.pan.y) *
eagernessFactor *
Math.sign(e.deltaY),
eagernessFactor *
Math.sign(e.deltaY),
},
zoom: e.deltaY <= 0 ? prev.zoom * 1.05 : prev.zoom / 1.05,
}));
Expand Down Expand Up @@ -740,8 +740,8 @@ export default function Canvas() {
}}
/>
))}
{relationships.map((e, i) => (
<Relationship key={i} data={e} />
{relationships.map((e) => (
<Relationship key={e.id} data={e} />
))}
{tables.map((table) => (
<Table
Expand Down
14 changes: 6 additions & 8 deletions src/components/EditorHeader/Modal/New.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,20 @@ export default function New({ selectedTemplateId, setSelectedTemplateId }) {
<div className="grid grid-cols-3 gap-2 overflow-auto px-1">
<div onClick={() => setSelectedTemplateId(0)}>
<div
className={`rounded-md h-[180px] border-2 hover:border-dashed ${
selectedTemplateId === 0 ? "border-blue-400" : "border-zinc-400"
}`}
className={`rounded-md h-[180px] border-2 hover:border-dashed ${selectedTemplateId === 0 ? "border-blue-400" : "border-zinc-400"
}`}
>
<Thumbnail i={0} diagram={{}} zoom={0.24} theme={settings.mode} />
</div>
<div className="text-center mt-1">{t("blank")}</div>
</div>
{templates?.map((temp, i) => (
<div key={i} onClick={() => setSelectedTemplateId(temp.id)}>
{templates?.map((temp) => (
<div key={temp.id} onClick={() => setSelectedTemplateId(temp.id)}>
<div
className={`rounded-md h-[180px] border-2 hover:border-dashed ${
selectedTemplateId === temp.id
className={`rounded-md h-[180px] border-2 hover:border-dashed ${selectedTemplateId === temp.id
? "border-blue-400"
: "border-zinc-400"
}`}
}`}
>
<Thumbnail
i={temp.id}
Expand Down
4 changes: 2 additions & 2 deletions src/pages/Templates.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default function Templates() {
<div className="grid xl:grid-cols-3 grid-cols-2 sm:grid-cols-1 gap-10 my-6">
{defaultTemplates?.map((t, i) => (
<div
key={i}
key={t.id}
className="bg-gray-100 hover:translate-y-[-6px] transition-all duration-300 border rounded-md"
>
<div className="h-48">
Expand Down Expand Up @@ -108,7 +108,7 @@ export default function Templates() {
<div className="grid xl:grid-cols-3 grid-cols-2 sm:grid-cols-1 gap-8 my-6">
{customTemplates?.map((c, i) => (
<div
key={i}
key={c.id}
className="bg-gray-100 hover:translate-y-[-6px] transition-all duration-300 border rounded-md"
>
<div className="h-48">
Expand Down