-
Notifications
You must be signed in to change notification settings - Fork 752
update(deps): bump to libs 0.21 #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b54482f to
a1dcd90
Compare
416bf65 to
f6874e4
Compare
c16319d to
0da7c2f
Compare
dbef5b7 to
490cdf2
Compare
irozzo-1A
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @therealbobo, this is great! and should address #2165 as well without having to cherry-pick fixes in the 0.20. libs branch.
Apart from a few nits, I think there are a few things we should address though.
- I got a segfault when trying it this way, to be further investigated, but I think this may be related to: falcosecurity/plugins#1019
$ sudo build/userspace/sysdig/sysdig --modern-bpf -p"%container.name" container.name!=host
dir: /usr/local/share/sysdig/plugins/
Segmentation fault
- IMO we should better handle the case in which the container plugin is not present in the fs, it's true that this should not happen when installing sysdig through package manager, but I think loosing the ability of using it standalone could be a limitation, especially for dev experience. I left a dedicated comment for this.
- falcosecurity/plugins#1046 we fixed a memleak with CRI container runtime we should probably cherry-pick to the container plugin version that works with libs
0.21, not a blocking point maybe as this should be less critical for a tool as sysdig, but we should consider it IMO
|
@therealbobo Unfortunately the latest plugin version I'm checking if we could cherry-pick falcosecurity/plugins#1019 and falcosecurity/plugins#1046 and create a 0.3.2 plugin release. |
This should make it, instead of cherry-picking the required changes to a previous version, we could make sure the container plugin is still compatible with libs |
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
3a92386 to
142be17
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
irozzo-1A
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
No description provided.