Skip to content

Conversation

@therealbobo
Copy link
Contributor

No description provided.

@therealbobo therealbobo force-pushed the bump-libs branch 6 times, most recently from b54482f to a1dcd90 Compare August 28, 2025 21:09
@therealbobo therealbobo force-pushed the bump-libs branch 15 times, most recently from 416bf65 to f6874e4 Compare October 15, 2025 08:20
@therealbobo therealbobo marked this pull request as ready for review October 15, 2025 08:23
@therealbobo therealbobo force-pushed the bump-libs branch 4 times, most recently from c16319d to 0da7c2f Compare October 17, 2025 12:54
@therealbobo therealbobo force-pushed the bump-libs branch 2 times, most recently from dbef5b7 to 490cdf2 Compare October 17, 2025 13:57
Copy link
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @therealbobo, this is great! and should address #2165 as well without having to cherry-pick fixes in the 0.20. libs branch.
Apart from a few nits, I think there are a few things we should address though.

  1. I got a segfault when trying it this way, to be further investigated, but I think this may be related to: falcosecurity/plugins#1019
$ sudo build/userspace/sysdig/sysdig --modern-bpf -p"%container.name" container.name!=host
dir: /usr/local/share/sysdig/plugins/
Segmentation fault
  1. IMO we should better handle the case in which the container plugin is not present in the fs, it's true that this should not happen when installing sysdig through package manager, but I think loosing the ability of using it standalone could be a limitation, especially for dev experience. I left a dedicated comment for this.
  2. falcosecurity/plugins#1046 we fixed a memleak with CRI container runtime we should probably cherry-pick to the container plugin version that works with libs 0.21, not a blocking point maybe as this should be less critical for a tool as sysdig, but we should consider it IMO

@irozzo-1A
Copy link
Contributor

@therealbobo Unfortunately the latest plugin version 0.42 is not compatible with the libs 0.21, because the required plugin API version is too low:

cannot load plugin /usr/local/share/sysdig/plugins/libcontainer.so: plugin required API version '3.12.0' not compatible with the framework's API version '3.11.0': framework's minor is less than the requested one

I'm checking if we could cherry-pick falcosecurity/plugins#1019 and falcosecurity/plugins#1046 and create a 0.3.2 plugin release.
cc @leogr

@irozzo-1A
Copy link
Contributor

irozzo-1A commented Nov 19, 2025

I'm checking if we could cherry-pick falcosecurity/plugins#1019 and falcosecurity/plugins#1046 and create a 0.3.2 plugin release. cc @leogr

This should make it, instead of cherry-picking the required changes to a previous version, we could make sure the container plugin is still compatible with libs 0.21.

@leogr leogr self-requested a review November 19, 2025 10:12
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Copy link
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@therealbobo therealbobo merged commit e89ee29 into draios:dev Nov 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants