Skip to content

test: fix pull failure assertion for Docker v29 #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardobranco777 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

test: fix pull failure assertion for Docker v29 #13564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/e2e/pull_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,15 @@ func TestComposePull(t *testing.T) {

t.Run("Verify pull failure", func(t *testing.T) {
res := c.RunDockerComposeCmdNoCheck(t, "--project-directory", "fixtures/compose-pull/unknown-image", "pull")
res.Assert(t, icmd.Expected{ExitCode: 1, Err: "pull access denied for does_not_exists"})
output := res.Combined()

errMsg := "pull access denied for does_not_exists"
if !strings.Contains(output, errMsg) {
// containerd returns:
// failed to resolve reference "docker.io/library/does_not_exists:latest": docker.io/library/does_not_exists:latest: not found
errMsg = "does_not_exists:latest: not found"
}
res.Assert(t, icmd.Expected{ExitCode: 1, Err: errMsg})
})

t.Run("Verify ignore pull failure", func(t *testing.T) {
Expand Down