Update ls_manifest.py #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load manifest safely in binary mode with optional bz2 decompression. Open manifest_file using 'rb' to prevent automatic UTF-8 decoding of compressed data. Call bz2.decompress() only when the filename ends with .bz2; otherwise pass the raw bytes through. Decode the resulting bytes to UTF-8 before json.loads(). Update CLI help string to reflect support for both .json and .json.bz2. Fixes: UnicodeDecodeError when a .bz2 file was read in text mode. TypeError when bz2.decompress() was called on an already-decoded .json file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load manifest safely in binary mode with optional bz2 decompression.
Open manifest_file using 'rb' to prevent automatic UTF-8 decoding of compressed data.
Call bz2.decompress() only when the filename ends with .bz2; otherwise pass the raw bytes through.
Decode the resulting bytes to UTF-8 before json.loads().
Update CLI help string to reflect support for both .json and .json.bz2.
Fixes:
UnicodeDecodeError when a .bz2 file was read in text mode.
TypeError when bz2.decompress() was called on an already-decoded .json file.