-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update toolbar panel styles #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3f30dd2 to
519259f
Compare
5c112fe to
18924ee
Compare
633954d to
f49750d
Compare
for more information, see https://pre-commit.ci
|
This is great! Thank you so much.
We don't have any solid leads on a designer for the redesign effort, so I think we're good to merge something like this in. |
|
Thank you for the feedback! And sorry to hear you did not find any solid leads on a designer, I was looking forward to that. Right now this branch is mostly a bunch of experiments, some incomplete, some broken, but what I can do is extract some of the changes that seem to work well and open separate pull requests for them. Does that sound right? That way a missing consensus on some parts does not block the whole effort (and it's also much easier to review). |
|
As an aside, I think moving toward shadow DOM rendering could make future design improvements much easier. It removes the need for overly defensive styling (such as prefixing/scoping everything) to avoid interference from the host page’s styles, and even with those measures, complete isolation isn’t always possible. |
I think that's probably best. If that's a problem I can make this one large PR work since it's mainly template and CSS code that's changing. |
Description
Hi! This is an initial attempt to give some of the toolbar panels a more modern and polished look, taking inspiration from the Django Admin styles.
I’m aware of the discussion in #2238 regarding a full redesign. This PR does not intend to compete or take over that effort. Rather, it’s a starting point to explore potential design directions with community feedback and potentially serve as a bridge before a full redesign is released. I may follow up with separate pull requests for individual improvements derived from this work.
Summary of changes
Checklist:
docs/changes.rst.