This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Implemented conditional logic based on fields values and different re… #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Advanced plugin
…direct + notification
# Conflicts: # aldryn_forms/admin/views.py # aldryn_forms/cms_plugins.py # aldryn_forms/contrib/email_notifications/cms_plugins.py
…m Advanced plugin
* add option to limit allowed extensions of file fields * convert serialization to utility function * add option to define files that should be attached to email * recognize extensions without the starting period * update help text
* add option to store file to filer (default=True) * remove misleading typehint
* create a copy of in-memory file to avoid unpredictability * format fix
* Added a custom error message field on extension validation * cleanup * only make the static string gettext lazy * Added accept attribute in frontend for file upload plugin * minor optimization
# Conflicts: # aldryn_forms/contrib/email_notifications/cms_plugins.py
kobecuppens1997
force-pushed
the
form-conditions-redirect-support
branch
from
193d033 to
ce63854
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirement for these changes was to have the ability to set the different redirect page and send different email notification if form was submitted with the specific value. For example, if a radio field has specific value "radio1".
According to this requirement I've implemented new fields for FormPlugin and EmailNotification models:
If new fields are empty then this logic is not enabled, so it's not affecting the original functionality.