Skip to content

Conversation

@jeverhart-dialpad
Copy link
Contributor

@jeverhart-dialpad jeverhart-dialpad commented Jan 20, 2026

fix(contact-info): DLT-2904 remove min-width from left section

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2904

📖 Description

Remove min-width style rule from the left section of DtRecipeContactInfo to allow that element to flex in width according to the content.

Direct link to storybook recipe previews: https://dialtone.dialpad.com/vue/index.html?path=/docs/recipes-item-layout-contact-info--docs

💡 Context

The previous min-width value appears to have been added for a specific use case, and we should allow that area to flex in width to support different content & avatar sizes. More background information available in the Jira ticket.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

For all CSS changes:

  • I have used design tokens whenever possible.
  • I have considered how this change will behave on different screen sizes.
  • I have visually validated my change in light and dark mode.
  • I have used gap or flexbox properties for layout instead of margin whenever possible.

🔮 Next Steps

Test specific usage to verify it will not cause existing layouts to break.

📷 Screenshots / GIFs

Screenshot 2026-01-20 at 4 51 15 PM

🔗 Sources

@github-actions
Copy link
Contributor

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@jeverhart-dialpad jeverhart-dialpad added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Jan 20, 2026
@github-actions
Copy link
Contributor

✔️ Deploy previews ready!
😎 Dialtone documentation preview: https://dialtone.dialpad.com/deploy-previews/pr-1032/
😎 Dialtone-vue preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-1032/

@francisrupert
Copy link
Contributor

@jeverhart-dialpad Thanks for sticking with this. I remain convinced there's no reason for min-width here at all, and its contents dictate its width ("hug" basically). Appreciate the usage findings too.

Move to Ready for Review at your discretion.

@jeverhart-dialpad
Copy link
Contributor Author

jeverhart-dialpad commented Jan 22, 2026

@jeverhart-dialpad Thanks for sticking with this. I remain convinced there's no reason for min-width here at all, and its contents dictate its width ("hug" basically). Appreciate the usage findings too.

Move to Ready for Review at your discretion.

Thanks, there's only 1 place I can't test and I have a message out to that engineering team. Moving to Ready for Review but won't merge until I hear back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants