-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix #2608 #2609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix #2608 #2609
Conversation
|
This is really good, but it will require additional reviewers. It might also mess up the build process. |
- Updated angular-original-wordmark.svg to use simplified IDs and removed unnecessary attributes. - Cleaned up the structure of angular-original.svg for consistency and readability.
Oh, we can't use VScode compressed SVG function, which will modify the id attribute, causing the id attribute of each SVG file to be the same, which will reproduce the problem of #2608 |
|
@weh Now I have compressed the contents of these 123 SVG files into one line, and I checked each file. There are no syntax errors and they can be displayed correctly. I used this script to check and modify the file: # powershell
# Run in the target folder: Set-Location 'c:\code\devicon'
Get-ChildItem -Path . -Recurse -Filter *.svg | ForEach-Object {
$path = $_.FullName
$text = Get-Content -Raw -Path $path
# Replace newlines and tabs with spaces, merge consecutive spaces into 1 space, and remove spaces between labels
$text = $text -replace '\r?\n|\t', ' '
$text = $text -replace '\s{2,}', ' '
$text = $text -replace '>\s+<', '><'
# Save (preserve UTF8)
Set-Content -Path $path -Value $text -Encoding UTF8
}In addition, I noticed that not all SVG files are compressed. Here I show that a total of 1758 files have been modified:
I can open a new PR request to submit changes if needed. |







Fixed 123 SVG ICONS that might have color confusion when used on the same component