Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented May 18, 2020


🚨 Your version of actionpack has known security vulnerabilities 🚨

Advisory: CVE-2020-8164
Disclosed: May 18, 2020
URL: https://groups.google.com/forum/#!topic/rubyonrails-security/f6ioe4sdpbY

Possible Strong Parameters Bypass in ActionPack

There is a strong parameters bypass vector in ActionPack.

Versions Affected: rails <= 6.0.3
Not affected: rails < 4.0.0
Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact

In some cases user supplied information can be inadvertently leaked from
Strong Parameters. Specifically the return value of each, or each_value,
or each_pair will return the underlying "untrusted" hash of data that was
read from the parameters. Applications that use this return value may be
inadvertently use untrusted user input.

Impacted code will look something like this:

def update
  # Attacker has included the parameter: `{ is_admin: true }`
  User.update(clean_up_params)
end

def clean_up_params
params.each { |k, v| SomeModel.check(v) if k == :name }
end

Note the mistaken use of each in the clean_up_params method in the above
example.

Workarounds

Do not use the return values of each, each_value, or each_pair in your
application.


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rails (5.2.4.2 β†’ 5.2.4.3) Β· Repo

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actioncable (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actionmailer (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actionpack (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ actionview (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activejob (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activemodel (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activerecord (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ activestorage (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

↗️ activesupport (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ loofah (indirect, 2.4.0 β†’ 2.5.0) Β· Repo Β· Changelog

Release Notes

2.5.0 (from changelog)

Features

  • Allow more CSS length units: "ch", "vw", "vh", "Q", "lh", "vmin", "vmax". [#178] (Thanks, @JuanitoFatas!)

Fixes

  • Remove comments from Loofah::HTML::Documents that exist outside the html element. [#80]

Other changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ mimemagic (indirect, 0.3.4 β†’ 0.3.5) Β· Repo Β· Changelog

Release Notes

0.3.5 (from changelog)

Mimetype extensions are now ordered by freedesktop.org's priority

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 2 commits:

↗️ minitest (indirect, 5.14.0 β†’ 5.14.1) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ railties (indirect, 5.2.4.2 β†’ 5.2.4.3) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ tzinfo (indirect, 1.2.6 β†’ 1.2.7) Β· Repo Β· Changelog

Release Notes

1.2.7

  • Fixed 'wrong number of arguments' errors when running on JRuby 9.0. #114.
  • Fixed warnings when running on Ruby 2.8. #112.

TZInfo v1.2.7 on RubyGems.org

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 19 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 18, 2020
@depfu depfu bot force-pushed the depfu/update/group/rails-5.2.4.3 branch from 341d05b to 805c4e6 Compare May 18, 2020 20:27
@depfu depfu bot changed the title 🚨 [security] Update all of rails: 5.2.4.2 β†’ 5.2.4.3 (patch) 🚨 [security] Update all of rails: 5.2.4.2 β†’ 5.2.4.3 (patch) May 18, 2020
@depfu
Copy link
Contributor Author

depfu bot commented May 18, 2020

Closed in favor of #193.

@depfu depfu bot closed this May 18, 2020
@depfu depfu bot deleted the depfu/update/group/rails-5.2.4.3 branch May 18, 2020 20:29
@depfu depfu bot reopened this May 19, 2020
@depfu depfu bot restored the depfu/update/group/rails-5.2.4.3 branch May 19, 2020 09:35
@depfu
Copy link
Contributor Author

depfu bot commented Sep 9, 2020

Closed in favor of #207.

@depfu depfu bot closed this Sep 9, 2020
@depfu depfu bot deleted the depfu/update/group/rails-5.2.4.3 branch September 9, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant