Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Oct 13, 2019

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ sidekiq (6.0.0 → 6.0.2) · Repo · Changelog

Release Notes

6.0.2 (from changelog)

  • Fix Sidekiq Enterprise's rolling restart functionality, broken by refactoring in 6.0.0. [#4334]
  • More internal refactoring and performance tuning [fatkodima]

6.0.1 (from changelog)

  • Performance tuning, Sidekiq should be 10-15% faster now [#4303, 4299, 4269, fatkodima]
  • Dark Mode support in Web UI (further design polish welcome!) [#4227, mperham, fatkodima, silent-e]
  • Job-specific log levels, allowing you to turn on debugging for problematic workers. [fatkodima, #4287]
MyWorker.set(log_level: :debug).perform_async(...)
  • Ad-hoc job tags. You can tag your jobs with, e.g, subdomain, tenant, country, locale, application, version, user/client, "alpha/beta/pro/ent", types of jobs, teams/people responsible for jobs, additional metadata, etc. Tags are shown on different pages with job listings. Sidekiq Pro users can filter based on them [fatkodima, #4280]
class MyWorker
  include Sidekiq::Worker
  sidekiq_options tags: ['bank-ops', 'alpha']
  ...
end
  • Fetch scheduled jobs in batches before pushing into specific queues. This will decrease enqueueing time of scheduled jobs by a third. [fatkodima, #4273]
ScheduledSet with 10,000 jobs
Before: 56.6 seconds
After:  39.2 seconds
  • Compress error backtraces before pushing into Redis, if you are storing error backtraces, this will halve the size of your RetrySet in Redis [fatkodima, #4272]
RetrySet with 100,000 jobs
Before: 261 MB
After:  129 MB
  • Support display of ActiveJob 6.0 payloads in the Web UI [#4263]
  • Add SortedSet#scan for pattern based scanning. For large sets this API will be MUCH faster than standard iteration using each. [fatkodima, #4262]
  Sidekiq::DeadSet.new.scan("UnreliableApi") do |job|
    job.retry
  end
  • Dramatically speed up SortedSet#find_job(jid) by using Redis's ZSCAN support, approx 10x faster. [fatkodima, #4259]
zscan   0.179366   0.047727   0.227093 (  1.161376)
enum    8.522311   0.419826   8.942137 (  9.785079)
  • Respect rails' generators test_framework option and gracefully handle extra worker suffix on generator [fatkodima, #4256]
  • Add ability to sort 'Enqueued' page on Web UI by position in the queue [fatkodima, #4248]
  • Support Client.push_bulk with different delays [fatkodima, #4243]
Sidekiq::Client.push_bulk("class" => FooJob, "args" => [[1], [2]], "at" => [1.minute.from_now.to_f, 5.minutes.from_now.to_f])
  • Easier way to test enqueuing specific ActionMailer and ActiveRecord delayed jobs. Instead of manually parsing embedded class, you can now test by fetching jobs for specific classes. [fatkodima, #4292]
assert_equal 1, Sidekiq::Extensions::DelayedMailer.jobs_for(FooMailer).size
  • Add sidekiqmon to gemspec executables [#4242]
  • Gracefully handle Sidekiq.logger = nil [#4240]
  • Inject Sidekiq::LogContext module if user-supplied logger does not include it [#4239]

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ redis (indirect, 4.1.2 → 4.1.3) · Repo · Changelog

Release Notes

4.1.3 (from changelog)

  • Fix the client hanging forever when connecting with SSL to a non-SSL server. See #835.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 13, 2019
@depfu
Copy link
Contributor Author

depfu bot commented Oct 26, 2019

Closed in favor of #167.

@depfu depfu bot closed this Oct 26, 2019
@depfu depfu bot deleted the depfu/update/sidekiq-6.0.2 branch October 26, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant