-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Treat -pre version suffix as prerelease.
#10207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot @dbrant , could you please add a test and we can get this over the line :) |
whoops, of course -- how about now? |
|
Merged and deployed! Thanks @dbrant !! |
|
For what it's worth, we discussed this in the past at #6747 and decided not to deviate from what Funny enough, when we rejected adding "-preview", I actually mentioned "-pre" explicitly:
|
|
Well, it was not really a clear decision, I totally understand taking the pragmatic approach over the correct, consistent one. Just saying that if we decide to do this, we may also want to reopen #6747. |
|
@jonjanego Thanks for the note, and no worries -- it looks like we'll need to convince the MapLibre developers to adopt more standard prerelease versions instead. |
|
The Dependabot team has decided to align strictly with Maven qualifiers: This alignment makes sense for consistency across tools. Yet recurring issues show that Maven’s current handling of qualifiers is incomplete, impacting multiple companies and users:
These issues need to be addressed upstream in Maven Resolver. I am working to encourage Maven to adopt a fix through this PR: The voice of users and teams such as Dependabot can strongly influence Maven’s willingness to integrate this into Maven 4. Proposed ordering:
I edited the documentation to discourage the use of certain qualifiers:
As long as discouraged qualifiers continue to be used in practice, tools will still need to support them. Once they are phased out, however, support can be safely dropped. Optional inclusions:
Target PR to support: Supporting this upstream effort helps turn recurring patches into a durable solution for the ecosystem. You can help by adding your voice on the Maven Resolver PR — for example, by sharing which qualifiers affect your projects, or by confirming that consistent ordering would reduce the need for local workarounds. Demonstrating real impact from tools like Dependabot makes it harder for Maven to ignore these changes. Thanks for your input. |
What are you trying to accomplish?
Certain projects release packages with pre-release versions that have a suffix of
-preN, which doesn't seem to get caught by dependabot as a prerelease, and gets submitted in a pull request as a stable package.example prerelease:
https://github.com/maplibre/maplibre-native/releases/tag/android-v11.0.2-pre0
example erroneous pull request:
wikimedia/apps-android-wikipedia#4806