fix: improve sending tx & error handling via legacy client #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| status.type === 'Drop' | ||
| ) { | ||
| unsub?.().catch(noop); | ||
| } |
There was a problem hiding this comment.
Bug: Callback promise rejection becomes unhandled
In send, the subscription callback is invoked without await/return. If callback throws or returns a rejected promise, the failure is detached from the RPC update handler, increasing the chance of unhandled promise rejections and also skipping the later cleanup path (like unsub?.()), leaving the watch active.
| deferTx.resolve(x); | ||
| } | ||
| }) | ||
| .catch(deferTx.reject); |
There was a problem hiding this comment.
Bug: Auto-unsubscribe can miss early terminal status
unsub is assigned asynchronously in the .then after author_submitAndWatchExtrinsic, but the terminal-state cleanup calls unsub?.() inside the status callback. If a terminal status arrives before .then runs (provider timing differences), unsub stays undefined and the subscription may remain open indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying CI