fix(consensus): use actual round in LocallyProposedValue #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ChannelValueBuilder::build_value()to use the actualroundparameter instead of hardcodingRound::new(0)Root Cause
The
build_valuefunction signature received aroundparameter (prefixed with_to suppress unused warnings), but the implementation ignored it and always createdLocallyProposedValuewithRound::new(0). Malachite consensus validates that proposal rounds match the current consensus round, so proposals with round=0 were silently rejected when consensus had advanced beyond round 0.Changes
crates/consensus/src/host.rs:_round: ConsensusRound→round: ConsensusRound(use the parameter)LocallyProposedValue::new(height, Round::new(0), value)→LocallyProposedValue::new(height, round, value)Test Plan
cargo check -p cipherbft-consensuspassescargo fmt -p cipherbft-consensusproduces no changes