fix: use correct round in LocallyProposedValue #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qj0r9j0vc2
force-pushed
the
fix/proposal-round-mismatch
branch
from
3ba848e to
3f30bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes proposal round mismatch causing consensus to ignore all proposals.
Problem:
build_value()ignored theroundparameter and always usedRound::new(0). When consensus requested a proposal at round 6+, the returned value had round 0, causing malachite to reject it with "Ignoring value for round 0, current round: 6".Solution: Use the
roundparameter passed by consensus instead of hardcodingRound::new(0).