Skip to content

fix: retain cut in pending_cuts for re-proposals #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qj0r9j0vc2 merged 1 commit into from
Jan 20, 2026
Merged

fix: retain cut in pending_cuts for re-proposals #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/consensus/src/host.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,9 +886,14 @@ impl ValueBuilder for ChannelValueBuilder {

loop {
// Check if we have a cut
// NOTE: We use get() instead of remove() to keep the cut available for
// potential re-proposals in different rounds. Without this, if consensus
// moves to a new round (e.g., due to timeouts) and asks for the same height
// again, the cut would already be gone. The cut will be cleaned up by the
// retention logic when newer heights arrive.
{
let mut pending = self.pending_cuts.write().await;
if let Some(cut) = pending.remove(&height) {
let pending = self.pending_cuts.read().await;
if let Some(cut) = pending.get(&height).cloned() {
let value = ConsensusValue::from(cut.clone());
let value_id = informalsystems_malachitebft_core_types::Value::id(&value);

Expand Down