Skip to content

[WIP] Redraw fixes #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
DaveDavenport wants to merge 48 commits into
base: next
Choose a base branch
from
Draft

[WIP] Redraw fixes #2220

DaveDavenport wants to merge 48 commits into from

Conversation

@DaveDavenport
Copy link
Collaborator

@DaveDavenport DaveDavenport commented Oct 20, 2025

Please follow these steps before submitting your PR:

  • This PR targets the next branch and not master
  • If your PR is a work in progress, include [WIP] in its title
  • Its commits' summaries are reasonably descriptive
  • You've described what this PR addresses below
  • You've included links to relevant issues, if any with #issue_num
  • You've deleted this template

Thank you for contributing to rofi! <3

Your description here...

@DaveDavenport
[Widget] Recalculate sizes when new sizes are known
7ff47a4
@DaveDavenport
[Widget] Don't update if size is not updated
3b06dc9
@DaveDavenport
[Textbox] Don't use two methods to calculate height.
c9aba77
@DaveDavenport
[Icon] Fix more sizing issues
69d83c1
@DaveDavenport
[textbox|icon] Avoid pointless redraws.
ad3c941
@DaveDavenport
More redrawing checks
51f03f3
@DaveDavenport
[Modes] add get_icon_names
d53791a
@DaveDavenport
[Icon] Try to size the image better.
e337ce1
@DaveDavenport
[Box] expanding widgets are active too
2b13c31
@DaveDavenport
Update most modes to use new system.
14203a2
@DaveDavenport
[Window] Re-add icon from window and window screenshot
e8cc9e0
@DaveDavenport
[Mode] Remove the old _get_icon method
0f97508
@DaveDavenport
Remove some printfs used for debugging, remove old code.
1e47e05
@DaveDavenport
Merge remote-tracking branch 'origin/next' into redraw-fixes
2a3760d
@DaveDavenport
Merge remote-tracking branch 'origin/next' into redraw-fixes
57caf62
@DaveDavenport
Merge remote-tracking branch 'origin/next' into redraw-fixes
3bcad99
@DaveDavenport
Buffer widgets surface
adf57db
@DaveDavenport
[IconFetcher] Improve some variable naming
9ec1404
@DaveDavenport
[Icon] remove from list more aggressively, removed unused code.
f078590
@DaveDavenport
Merge remote-tracking branch 'origin/next' into redraw-fixes
fc8ef03
@DaveDavenport
Merge remote-tracking branch 'origin/next' into redraw-fixes
9600932
@DaveDavenport
[Widget] add ref counting to widget and redraw debug output.
5ac3c57
@DaveDavenport
Merge remote-tracking branch 'origin/redraw-fixes' into redraw-fixes
9a1c635
@DaveDavenport
[Icon] Fix same icon not loaded in multiple widgets in some cases.
3fafd82
@DaveDavenport
[Mode] Re-add fallback icon.
c4051f0
@DaveDavenport
[IconFetcher] Handle wid == NULL
d1f8749
@DaveDavenport
Merge remote-tracking branch 'origin/next' into redraw-fixes
e2afc21
@DaveDavenport DaveDavenport marked this pull request as draft October 20, 2025 08:36
lbonn
lbonn reviewed Oct 26, 2025
View reviewed changes
lbonn
lbonn approved these changes Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@lbonn lbonn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the requested changes are in #2241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbonn lbonn lbonn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaveDavenport @lbonn