PLUGIN-1939: Adding nullable split support in DB plugins. #637
+178
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
database-commons/src/main/java/io/cdap/plugin/db/source/DataDrivenETLDBInputFormat.java
Show resolved
Hide resolved
database-commons/src/main/java/io/cdap/plugin/db/source/DataDrivenETLDBInputFormat.java
Show resolved
Hide resolved
database-commons/src/main/java/io/cdap/plugin/db/source/DataDrivenETLDBInputFormat.java
Show resolved
Hide resolved
anup-cloudsufi
force-pushed
the
bugfix/plugin-1939
branch
from
1f3416a to
66902e5
Compare
MrRahulSharma
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: partitioned reads on an Oracle table would skip any records where the partitioning column (split-by column) contained a
NULLvalue. This caused data loss and incorrect record counts because the underlying logic only generated splits for non-null value ranges. This is applicable for other DB plugins.Changes involved:
DataDrivenETLDBInputFormat.getSplitsto check the generated splits and if no split covering all records or a specificIS NULLsplit is found, adds a dedicatedInputSplitusing the condition[splitByColumn] IS NULL.