Add available widths and heights #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent a DOS attack on exposed API, as described here: https://github.com/oo12/phpThumbOf/wiki/Thumb-War Two new system settings are required: phpthumbsup.available_widths phpthumbsup.available_heights and added to the $config array. is_available_option checks for these, and if not matched in the request the image is not processed for that option. Note on upgrade, this will prevent processing of images in a site with pre-existing install, but now that the exposed API vulnerability is brought to light it's a pretty important patch, IMHO. Could wrap the whole thing in a condition that checks for values in those settings, or another setting to turn this functionality on/off...
Synced with changes in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate DOS attack on exposed API, as described here:
https://github.com/oo12/phpThumbOf/wiki/Thumb-War
Two new system settings are required:
phpthumbsup.available_widths
phpthumbsup.available_heights
and added to the $config array. is_available_option checks for these, and if not matched in the request the image is not processed for that option.
Note on upgrade, this will prevent processing of images in a site with pre-existing install, but now that the exposed API vulnerability is brought to light it's a pretty important patch, IMHO.
Could wrap the whole thing in a condition that checks for values in those settings, or another setting to turn this functionality on/off...
**Also modified build script to add system settings