Encode s3 bucket access log format into Terraform #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
pinging @CodyCBakerPhD since he wanted me to make some changes to this. |
waxlamp
approved these changes
Jul 15, 2025
Member
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
Code changes look fine; need to rebase to master to get a cleaner TF plan.
mvandenburgh
force-pushed
the
upgrade-aws-provider
branch
from
3cf8282 to
bf6f274
Compare
Member
Author
|
Looks like the AWS provider changed some other stuff in v6, which caused some unintended changes for other resources. I'll put this in draft for now |
mvandenburgh
force-pushed
the
upgrade-aws-provider
branch
from
4da30ff to
02a0196
Compare
mvandenburgh
force-pushed
the
upgrade-aws-provider
branch
from
02a0196 to
01d3df9
Compare
brianhelba
force-pushed
the
update-resonant-module
branch
2 times, most recently
from
4bb0090 to
b917219
Compare
brianhelba
force-pushed
the
update-resonant-module
branch
from
b917219 to
2c3616e
Compare
This field was added in v6 of the AWS provider. See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_logging#target_object_key_format
mvandenburgh
force-pushed
the
upgrade-aws-provider
branch
from
01d3df9 to
3229e04
Compare
brianhelba
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had some confusion around the "log object key format" that is set for access logging of our S3 buckets. Due to it being modified directly in the AWS console instead of through a PR to this repo, it went unnoticed for some time. It turns out that, until recently, the AWS Terraform module didn't support configuring this setting anyway. This PR adds configuration for the log object key format.
Support for specifying the log object key format was added in AWS provider v6 (we are on v5), so this PR is dependent on/based off of #236.