Don't return null names or usernames from user search endpoint
#2681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
commented
Dec 30, 2025
| """Serialize a user that's been annotated with a `social_account_data` field.""" | ||
| username = user.username | ||
| name = f'{user.first_name} {user.last_name}'.strip() | ||
| name = user.get_full_name() |
Member
Author
There was a problem hiding this comment.
This function on the User model is exactly the same as what we're doing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the API, where if a user has a value of
nullin their social accountnamefield, their user isn't properly displayed in the user search (used mainly in the GUI). This in theory could also exist for theloginfield, but since the response from github is guaranteed to have that field filled out with the user's github username, it should be impossible.