Enhance arc() to support individual corner radii for rounded corners #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (rci.length === 1) rc = [rci[0], rci[0], rci[0], rci[0]]; | ||
| else if (rci.length === 2) rc = [rci[0], rci[1], rci[0], rci[1]]; | ||
| else if (rci.length === 3) rc = [rci[0], rci[1], rci[2], rci[1]]; | ||
| else if (rci.length === 4) rc = rci; |
There was a problem hiding this comment.
Could change that to else rc = rci.slice(0,4);, otherwise passing rci with more than 4 elements would never set rc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
arc.jsfile to allow individual corners to be rounded by passing an array of numbers. This change is based on the code by murtada58 and ensures backward compatibility with the previous method of passing a single number for uniform corner rounding.Changes include:
Please review and let me know if there are any further adjustments needed.
Note: I am currently unsure how to update the
d3-shapedocumentation to reflect these changes. Any guidance on this would be appreciated.Here is a custom build d3.mjs.zip of D3 version 7.9.0 (
d3.mjs) that includes these changes for immediate use.