Skip to content

Conversation

@nsryan2
Copy link
Member

@nsryan2 nsryan2 commented Apr 11, 2025

This PR closes #413 by removing lazy_asd.rst from source/python/, and the reference to it in the associated index.rst file.

As @gonuke pointed out, cyclus/cyclus#1393 and cyclus/cyclus#1400 seem to have removed the associated functionality from cyclus. I checked by grepping through cyclus and cycamore and did not find references to it (lazy_asd, lazy_asd.py, lazyasd, lazyobject, or lazy_asd) in the current source branch of the code.

Associated developers:
@gonuke
@abachma2

I was not able to build the docs using make html or make gh-preview, but I am happy to devote more time to check that if reviewers want. These changes are in line with the style of the project and the last couple of PRs.

@nsryan2 nsryan2 requested review from abachma2 and gonuke April 11, 2025 23:29
@nsryan2 nsryan2 self-assigned this Apr 11, 2025
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nsryan2

@gonuke
Copy link
Member

gonuke commented Apr 12, 2025

The good news is that

  • CI builds a version of the website
  • I downloaded it and it works
  • merging will build and deploy the website.

@gonuke gonuke merged commit 4370355 into cyclus:source Apr 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing cyclus.lazyasd in source/python/lazy_asd.py, module not found

2 participants