Skip to content

fix(cubestore): add statsd metrics bind address ENV VAR #9922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FlipEnergy wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(cubestore): add statsd metrics bind address ENV VAR #9922

FlipEnergy wants to merge 4 commits into from
+12 −1

Conversation

@FlipEnergy
Copy link

@FlipEnergy FlipEnergy commented Aug 26, 2025 •
edited by KSDaemon
Loading

… to non-localhost

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
Closes #9920

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 26, 2025
@FlipEnergy FlipEnergy marked this pull request as ready for review August 26, 2025 16:59
@FlipEnergy FlipEnergy requested a review from a team as a code owner August 26, 2025 16:59
@FlipEnergy FlipEnergy mentioned this pull request Aug 26, 2025
Open
KSDaemon
KSDaemon approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@FlipEnergy FlipEnergy force-pushed the dennis/metrics-bind-zero branch from 4dbb055 to 5bd9d27 Compare September 2, 2025 18:13
@FlipEnergy FlipEnergy force-pushed the dennis/metrics-bind-zero branch from 5bd9d27 to d00ef44 Compare October 3, 2025 15:36
@FlipEnergy
Copy link
Author

FlipEnergy commented Oct 3, 2025

Bump on this quick PR, would be great if we can get this merged ASAP. Thanks!

@KSDaemon
Copy link
Member

KSDaemon commented Oct 9, 2025

@ovr @waralexrom WDYT?

@avinashkadiyala-branch
Copy link

avinashkadiyala-branch commented Oct 14, 2025

@KSDaemon When do you think this PR will be merged? Waiting on this one to fix metrics issue in our self hosted deployment.

KSDaemon
KSDaemon reviewed Oct 15, 2025
View reviewed changes
@FlipEnergy FlipEnergy force-pushed the dennis/metrics-bind-zero branch from d00ef44 to 8289628 Compare November 19, 2025 18:22
@github-actions github-actions bot added cube store Issues relating to Cube Store rust Pull requests that update Rust code labels Nov 19, 2025
@FlipEnergy FlipEnergy force-pushed the dennis/metrics-bind-zero branch from 8289628 to bf4b84d Compare November 19, 2025 18:23
@FlipEnergy FlipEnergy force-pushed the dennis/metrics-bind-zero branch from bf4b84d to 5267753 Compare November 19, 2025 18:24
@FlipEnergy FlipEnergy changed the title fix(cubestore): bind to 0.0.0.0 for statsd metrics to be able to send… fix(cubestore): add statsd metrics bind address ENV VAR Nov 19, 2025
@FlipEnergy FlipEnergy requested a review from KSDaemon November 21, 2025 21:16
@FlipEnergy
Copy link
Author

FlipEnergy commented Dec 11, 2025

@KSDaemon Hoping for this small PR to get merged soon, friendly reminder. Thank you.

@KSDaemon
Copy link
Member

KSDaemon commented Dec 11, 2025

@FlipEnergy Yeah! thnx for reminding! I started CI, please run cargo fmt in changed project to fix formatting

@FlipEnergy
Copy link
Author

FlipEnergy commented Dec 11, 2025 •
edited
Loading

@FlipEnergy Yeah! thnx for reminding! I started CI, please run cargo fmt in changed project to fix formatting

@KSDaemon fmt done.

@FlipEnergy
Copy link
Author

FlipEnergy commented Dec 15, 2025

Any final things to do other than getting this merged? Are we waiting another approval? We're soooo close :)

@KSDaemon
Copy link
Member

KSDaemon commented Dec 18, 2025

@FlipEnergy I think we're good to go! We're in the process of merging the updated Cubestore, so let's merge it after we release 1.6.

@igorlukanin
Copy link
Member

igorlukanin commented Dec 23, 2025

Sorry for coming very late across this one.

@FlipEnergy Would you be so kind to add this one next to https://cube.dev/docs/product/configuration/reference/environment-variables#cubestore_metrics_address? Should be a small and trivial change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KSDaemon KSDaemon KSDaemon approved these changes

@waralexrom waralexrom waralexrom approved these changes

Assignees

@waralexrom waralexrom

Labels

cube store Issues relating to Cube Store pr:community Contribution from Cube.js community members. rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cubestore StatsD metrics fail to send to non-localhost

5 participants

@FlipEnergy @KSDaemon @avinashkadiyala-branch @igorlukanin @waralexrom