Dmitrijs Savkins #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up-ctc
reviewed
May 30, 2025
| { | ||
| path: 'guest-book', | ||
| loadChildren: () => | ||
| import('./guest-book/guest-book.routes').then((mod) => mod.routes), |
up-ctc
reviewed
May 30, 2025
| loadChildren: () => | ||
| import('./posts/posts.routes').then((mod) => mod.routes), | ||
| providers: [ | ||
| PostsService, |
There was a problem hiding this comment.
Service is providedIn: 'root'. It means it is initialized when app is loaded and this is good practice. It will guarantee that Service data is persisted. In praticular example since it was already loaded on app level, you are providing once more it means you are creating it again. So there will be two Services :)
up-ctc
reviewed
May 30, 2025
| it('should not load entries when they were already loaded', () => { | ||
| store.overrideSelector(selectUsersLoaded, true); | ||
| testScheduler.run(({ hot, expectObservable }) => { | ||
| actions$ = hot('-a--', { |
There was a problem hiding this comment.
Its very nice that you learned about marbles testing
up-ctc
reviewed
May 30, 2025
| GuestBookPageActions, | ||
| } from './guest-book.actions'; | ||
|
|
||
| export interface GuestBookState extends EntityState<GuestBookEntry> { |
There was a problem hiding this comment.
For convenience state interface and default state usually are in separate state.ts file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.