Support for Leader Ingress labels #236
Open
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Ingress resource does not have any labels set. This pull request addresses this issue by incorporating the 'logstream-leader.labels' definition into the Ingress resource.
Additionally, support for Ingress-specific labels has been added, providing flexibility when using features such as Ingress sharding, which requires labels to be set on Ingress objects.
After this change, we can set labels on the Ingress object directly from the
valuesfile:The resulting Ingress will have both common and Ingress-specific labels: