Skip to content

Conversation

@oree-xx
Copy link
Contributor

@oree-xx oree-xx commented Dec 19, 2025

Fixes

Description

I added a check_completion funtion for wikipedia_fetch.py and removed commented lines from github fetch.py

Checklist

  • I have read and understood the Developer Certificate of Origin (DCO), below, which covers the contents of this pull request (PR).
  • My pull request doesn't include code or content generated with AI.
  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated unit tests and/or test scripts for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@oree-xx oree-xx requested review from a team as code owners December 19, 2025 17:27
@oree-xx oree-xx requested review from TimidRobot and possumbilities and removed request for a team December 19, 2025 17:27
@oree-xx oree-xx changed the title Added a completion function. Add a completion function. Dec 19, 2025
@cc-open-source-bot cc-open-source-bot moved this to In review in TimidRobot Dec 19, 2025
@TimidRobot TimidRobot self-assigned this Dec 22, 2025
@TimidRobot
Copy link
Member

  • My pull request targets the default branch of the repository (main or master).

Please check this. The target branch is creativecommons:main.

@TimidRobot
Copy link
Member

  • I tried running the project locally and verified that there are no visible errors.

Did you test your changes?

  • If yes, please check this item
  • If no, please do so, and check this once there are no visible errors

try:
with open(FILE_LANGUAGES, "r", newline="") as file_obj:
reader = csv.DictReader(file_obj, dialect="unix")
if len(list(reader)) > 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure this tests more than the header please increase the required lines (maybe to 300).

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, almost there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants