Skip to content

Conversation

@SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Jan 8, 2026

This PR upgrades the thanos version to v0.40.1.
At the thanos-io/thanos@638bf44, the blocksCleaneris added to bucket compactor to fix thanos-io/thanos#8442.
In this PR, we pass nil to preserve the current behavior for now.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yeya24
Copy link
Contributor

yeya24 commented Jan 8, 2026

I wonder if Cortex has that bug but Cortex has a different code path. At least we run partition compactor mode which is totally different. Idk about the non partition compactor mode.

@SungJin1212
Copy link
Member Author

SungJin1212 commented Jan 9, 2026

@yeya24
Yeah, If the Cortex cleaner deletes a block just before GarbageCollect, the block which only contain deletion-mark.json could be exist.
But, the cleanUserPartialBlocks function in the cleaner specifically detects blocks that are missing meta.json but have a deletion mark, and hard-deletes them.
Therefore, this inconsistency is temporary. WDYT?

@yeya24
Copy link
Contributor

yeya24 commented Jan 9, 2026

Yeah I think the cleaner change is ok.
Can you help bump thanos version to latest main thanos-io/thanos#8625?
There are other nice improvements to pull

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the upgrade-thanos-version-v0.40.1 branch from 05e7ee2 to 3e1068a Compare January 11, 2026 22:55
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 11, 2026
@yeya24
Copy link
Contributor

yeya24 commented Jan 12, 2026

Let's avoid more changes to this PR. We should try to split projection hints and response batching to other PRs

@SungJin1212
Copy link
Member Author

@yeya24
Agree, can you take a look it?

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 048ea8a into cortexproject:master Jan 12, 2026
68 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compactor marks block for deletion after deletion

2 participants