-
Notifications
You must be signed in to change notification settings - Fork 847
upgrade thanos version to v0.40.1 #7199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade thanos version to v0.40.1 #7199
Conversation
|
I wonder if Cortex has that bug but Cortex has a different code path. At least we run partition compactor mode which is totally different. Idk about the non partition compactor mode. |
|
@yeya24 |
|
Yeah I think the cleaner change is ok. |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
05e7ee2 to
3e1068a
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
|
Let's avoid more changes to this PR. We should try to split projection hints and response batching to other PRs |
|
@yeya24 |
yeya24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR upgrades the thanos version to v0.40.1.
At the thanos-io/thanos@638bf44, the
blocksCleaneris added to bucket compactor to fix thanos-io/thanos#8442.In this PR, we pass
nilto preserve the current behavior for now.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]