Wavelet hash implementation #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks I will take a look :) |
Author
|
Should I rewrite tests without stretchr/testify to support go <1.13 ? |
Owner
|
Sorry for the delay, I was quite busy with day work. |
corona10
reviewed
May 12, 2023
Comment on lines
+49
to
+58
| {"_examples/sample1.jpg", "_examples/sample1.jpg", WaveletHash, "WaveletHash", 0}, | ||
| {"_examples/sample2.jpg", "_examples/sample2.jpg", WaveletHash, "WaveletHash", 0}, | ||
| {"_examples/sample3.jpg", "_examples/sample3.jpg", WaveletHash, "WaveletHash", 0}, | ||
| {"_examples/sample4.jpg", "_examples/sample4.jpg", WaveletHash, "WaveletHash", 0}, | ||
| {"_examples/sample1.jpg", "_examples/sample2.jpg", WaveletHash, "WaveletHash", 38}, | ||
| {"_examples/sample1.jpg", "_examples/sample3.jpg", WaveletHash, "WaveletHash", 2}, | ||
| {"_examples/sample1.jpg", "_examples/sample4.jpg", WaveletHash, "WaveletHash", 34}, | ||
| {"_examples/sample2.jpg", "_examples/sample3.jpg", WaveletHash, "WaveletHash", 40}, | ||
| {"_examples/sample2.jpg", "_examples/sample4.jpg", WaveletHash, "WaveletHash", 6}, | ||
| {"_examples/sample3.jpg", "_examples/sample4.jpg", WaveletHash, "WaveletHash", 36}, |
Owner
There was a problem hiding this comment.
Would you like to provide the result of python version?
Owner
Yes please :) |
corona10
requested changes
May 12, 2023
Owner
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
- Rebase the PR
- Rewrite the test without using the external package
- Provide the result of python version of test cases.
- Check the build failure of shift operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.