Skip to content

Wait until beforeSend header is returned before sending xhr request #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erasromani wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wait until beforeSend header is returned before sending xhr request #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/imageLoader/internal/xhrRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,18 @@ function xhrRequest(url, imageId, defaultHeaders = {}, params = {}) {
const xhr = new XMLHttpRequest();

xhr.open('get', url, true);
const beforeSendHeaders = options.beforeSend(
xhr,
imageId,
defaultHeaders,
params
);

let beforeSendHeaders = {};
try{
beforeSendHeaders = options.beforeSend(
Copy link
Contributor

@wayfarer3130 wayfarer3130 Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a synchronous call. This is also not the current version - there is an options.open method that runs before on line 23. Since this is already a promise, it should be easy to change this into an async function on line 4, then return the result directly down below.

Copy link
Member

@sedghi sedghi Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it seems to be outdated base, @erasromani can you please rebase?

xhr,
imageId,
defaultHeaders,
params
);
} catch(err) {
console.error(err);
}

xhr.responseType = 'arraybuffer';

Expand Down