Skip to content

fix(kiali): refactor workload logs tool #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manusa merged 6 commits into from
Dec 9, 2025
Merged

fix(kiali): refactor workload logs tool #538

manusa merged 6 commits into from
Dec 9, 2025

Conversation

@josunect
Copy link
Contributor

@josunect josunect commented Dec 3, 2025

  • Remove non used parameters
  • Remove container selection logic (Not needed)
  • Renamed -> kiali_workload_logs

@josunect
Update logs tool
f63bc32 
Signed-off-by: josunect <jcordoba@redhat.com>
@josunect
Rename kiali_logs
759869e 
Signed-off-by: josunect <jcordoba@redhat.com>
@josunect
Rerun
9f83397 
Signed-off-by: josunect <jcordoba@redhat.com>
@josunect
Rerun
d20649f 
Signed-off-by: josunect <jcordoba@redhat.com>
@josunect
Rerun
d9517d4 
Signed-off-by: josunect <jcordoba@redhat.com>
@josunect
Run CI
48ef68e 
Signed-off-by: josunect <jcordoba@redhat.com>
@manusa manusa self-requested a review December 4, 2025 09:10
@manusa manusa changed the title feat(kiali): Refactor workload logs tool fix(kiali): refactor workload logs tool Dec 9, 2025
@manusa manusa added this to the 0.1.0 milestone Dec 9, 2025
manusa
manusa approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@aljesusg is this OK for you?

aljesusg
aljesusg approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@aljesusg aljesusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

Yes @manusa , Sorry I didn't add the review.
I was waiting to merge this one first #507 But I'll rebase it

@manusa
Copy link
Member

manusa commented Dec 9, 2025

LGFM

Yes @manusa , Sorry I didn't add the review. I was waiting to merge this one first #507 But I'll rebase it

Thx, I'm trying to merge the low hanging fruit first.

@manusa manusa merged commit 6253524 into containers:main Dec 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manusa manusa manusa approved these changes

+1 more reviewer

@aljesusg aljesusg aljesusg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@josunect @manusa @aljesusg