Refactor/extract openscd dependencies #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tract-openscd-dependencies Refactor/extract openscd dependencies
…tract-openscd-dependencies feature: add translations for editor-plugins
…tract-openscd-dependencies feature: add translations for editor-plugins
trusz
reviewed
Apr 11, 2025
Comment on lines
+6
to
+8
| const language = localStorage.getItem('language') || 'en'; | ||
| console.log("SETTING LANGUAGE TO", language); | ||
| use(language); |
Contributor
There was a problem hiding this comment.
This is how plugins know which language to use?
Collaborator
Author
There was a problem hiding this comment.
Exactly. It's pretty much how OpenSCD does it when loading plugins internally.
Contributor
There was a problem hiding this comment.
A lot of the files are not needed, you just copied in the whole thing, right?
Collaborator
Author
There was a problem hiding this comment.
Yes i would need to refactor this and strip the imports i don't need 👍.
| }, | ||
| build: { | ||
| lib: { | ||
| entry: path.resolve(__dirname, 'apps/plugins/src/editors/Substation.ts'), |
Contributor
There was a problem hiding this comment.
so this is not relevant as we build the plugins with the script right?
Collaborator
Author
There was a problem hiding this comment.
Exactly. This is just in the application for testing purposes right now. So i can quickly build a single plugin.
Will be removed when final version is ready.
…tract-openscd-dependencies Refactor/extract openscd dependencies
…tract-openscd-dependencies refactor: update gh workflow
…tract-openscd-dependencies refactor: update gh workflow
…tract-openscd-dependencies fix: removed unnecessary renaming of wizard textfield
…tract-openscd-dependencies fix: remove snowpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.