fix: concatenate all Pdata chunks
#266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackahl
approved these changes
Sep 30, 2025
Member
jackahl
left a comment
jackahl
left a comment
There was a problem hiding this comment.
Tested it locally and seems to work fine for both cases with and without the Pdata wrapper
fredvd
requested changes
Oct 1, 2025
| ----------------- | ||
|
|
||
| - Nothing changed yet. | ||
| - Fixed data extraction to concatenate all `Pdata` chunks. [@jnptk] |
Member
There was a problem hiding this comment.
To be more precise, the fix in the Serializer is only for ATFileFields from the Archetypes contenttype system, where the binary Data of the FileField is stored in the ZODB instead of Blobstorage (using plone.app.blob). Most Plone sites with Archetypes would/should have been migrated or on install already use Blob based filefield storage in Plone 4.
A mnore precies changelog line could be along the lines of:
- Fixed data extraction of Archetypes ATFilefields to concatenate all 'Pdata' chunks, when the FileField data was still stored in Filestorage and not not migrated to use blobstorage (using plone.app.blobs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes data extraction from
Pdataobjects by traversing the entire linked list and concatenating all chunks, rather than only reading the first node's data.