Notifications update #667
Open
Notifications update #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawdaGastan
requested review from
AbdelrahmanElawady,
AlaaElattar,
maayarosama,
samaradel,
xmonader and
zaelgohary
as code owners
rawdaGastan
changed the base branch from
development
to
development_flat_payment
rawdaGastan
force-pushed
the
development_flat_payment
branch
from
26ced02 to
8f86730
Compare
…ud4students into development_notifications_update
xmonader
reviewed
Jan 15, 2025
| Seen bool `json:"seen" binding:"required"` | ||
| Notified bool `json:"notified" binding:"required"` | ||
| // to allow redirecting from notifications to the right pages | ||
| Type string `json:"type" binding:"required"` |
Collaborator
There was a problem hiding this comment.
What could be the types and how do they behave?
xmonader
approved these changes
Jan 15, 2025
rawdaGastan
force-pushed
the
development_flat_payment
branch
from
da94fa0 to
c75afcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues