🤖 fix: prevent empty content API error after stream interrupt #1079
+207
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stream is interrupted before producing content, an empty placeholder message could remain in chat history. On retry, this could cause:
Root Cause
commitToHistorydoesn't commit (no content) but doesn't delete the empty placeholderSolution
Two-pronged fix:
Defense-in-depth filtering in
transformModelMessagesfilterEmptyContentMessagespass that removes anyModelMessagewith empty content array or empty string contentClean up empty placeholders in
partialService.commitToHistoryhistoryService.deleteMessageBySequence()for targeted message deletionTests
transformModelMessagesdeleteMessageBySequenceinhistoryServiceGenerated with
mux