Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-15563

@rmloveland rmloveland requested review from fqazi and smcvey December 9, 2025 17:08
@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit b3bf9e4
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/69456dabad6ccc0008826ab1

@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit b3bf9e4
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/69456dabf6f300000845d91e

@netlify
Copy link

netlify bot commented Dec 9, 2025

Netlify Preview

Name Link
🔨 Latest commit b3bf9e4
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/69456dab50acd50008f103ce
😎 Deploy Preview https://deploy-preview-21560--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland
Copy link
Contributor Author

@smcvey @fqazi I hope this captures the nuance of which versions of CRDB are effected and under which conditions, please let me know if add'l changes are needed!

Copy link

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmloveland . We also want similar changes on newer releases.

@rmloveland
Copy link
Contributor Author

Looks good

thanks @fqazi !

We also want similar changes on newer releases.

oh interesting - the jira issue says "this only applies to versions before v25.1", sounds like that was incorrect?

are you saying we should make this doc update for all of the newer releases as well? (i.e., v25.1, v25.3, v25.4, and v26.1)

@fqazi
Copy link

fqazi commented Dec 17, 2025

@rmloveland I think it's because auto_commit_before_ddl is enabled by default on those releases. But users can also toggle it off on later releases, which this message covers. @smcvey Do you have any thoughts on this?

@smcvey
Copy link

smcvey commented Dec 17, 2025

We have had some customers switching off auto_commit_before_ddl after upgrading and discovering it had changed - it was breaking their schema changing tools so I think including it in later versions of the docs should still happen, but mention that only if auto_commit_before_ddl is disabled.

@rmloveland rmloveland force-pushed the 20251208-DOC-15563-vs-changefeed-schema-change-policy-nobackfill branch from 277b442 to 56a066a Compare December 18, 2025 17:14
@rmloveland
Copy link
Contributor Author

We have had some customers switching off auto_commit_before_ddl after upgrading and discovering it had changed - it was breaking their schema changing tools so I think including it in later versions of the docs should still happen, but mention that only if auto_commit_before_ddl is disabled.

ah ok thanks for that info @smcvey ! I have updated the v25.1 and later docs with the following in this commit:

However, if the schema change with column backfill runs inside an [explicit transaction]({% link {{ page.version.version }}/begin-transaction.md %}) and the [autocommit_before_ddl session setting]({% link {{page.version.version}}/set-vars.md %}#autocommit-before-ddl) is disabled, it will emit the entire table to the changefeed.

@rmloveland
Copy link
Contributor Author

thanks for the helpful comments and reviews, @fqazi and @smcvey - i'm gonna pass this to Docs team for internal review to get merged ASAP

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rmloveland rmloveland enabled auto-merge (squash) December 19, 2025 15:22
@rmloveland rmloveland merged commit fbae7c0 into main Dec 19, 2025
6 checks passed
@rmloveland rmloveland deleted the 20251208-DOC-15563-vs-changefeed-schema-change-policy-nobackfill branch December 19, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants