-
Notifications
You must be signed in to change notification settings - Fork 477
Archive v21.1 documentation #21417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive v21.1 documentation #21417
Conversation
- Remove LLM-generated openssl_fix.rb script - Remove debug file output.txt - Update sidebar_htmltest.rb to respect htmltest config and skip archived versions
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much LGTM modulo a couple changes (remove gemfile edit and i think the HTMLtest file will conflict during rebase) which should (?) be picked up after #21403 (previous in this series) goes in
| gem "webrick" | ||
| gem "jekyll-minifier" | ||
|
|
||
| gem "csv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as other PRs, please move gemfile changes to separate PR
| @@ -1,16 +1,36 @@ | |||
| require 'json' | |||
| require 'liquid' | |||
| require 'yaml' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebembi-crdb this LGTM once you implement the changes I mentioned in the comments. Wanted to unblock you on this since I will be on PTO for the holidays next week
- Add v21.1 offline documentation link to archived documentation page - Remove v21.1 specific files from repository - Revert Gemfile and sidebar_htmltest.rb changes per review feedback - Resolve merge conflicts with main branch
Resolved conflict in archived-documentation.md by keeping both v21.1 and v20.1 entries in the correct version order
Archives v21.1 documentation following the same process used for v2.1.