Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Dec 18, 2025

The controller would become then the owner of all fields, including the defaults, but they should just be the defaults.

@fwiesel fwiesel requested a review from notandy December 18, 2025 10:35
The controller would become then the owner of all fields,
including the defaults in spec, but they should just be the defaults.
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 50.23% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_controller.go 64.41% (ø) 59 38 21

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@notandy
Copy link
Contributor

notandy commented Dec 18, 2025

I've noticed that it's unknown since the patch updates, it used to be the managers name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants